<html>
<head><meta charset="utf-8"><title>pr-51729-move-diagnostics · t-compiler/wg-nll · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/index.html">t-compiler/wg-nll</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/pr-51729-move-diagnostics.html">pr-51729-move-diagnostics</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="128680668"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/pr-51729-move-diagnostics/near/128680668" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/pr-51729-move-diagnostics.html#128680668">(Jun 26 2018 at 21:16)</a>:</h4>
<p><span class="user-mention" data-user-id="116118">@Matthew Jasper</span> left various nits on #51729, but it looks really lovely. Think you'll be able to add the comments etc + rebase? (I'm asking because I'd rather land it than wait, if that's gonna take a while — but I guess it needs rebase either way)</p>



<a name="128733933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/pr-51729-move-diagnostics/near/128733933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthew Jasper <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/pr-51729-move-diagnostics.html#128733933">(Jun 27 2018 at 19:38)</a>:</h4>
<p>re: your last comment, I'm comparing scopes since the alternative was comparing spans that were only used for that. I think I might change back to comparing spans, since I think I'll need them later.</p>



<a name="128734054"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/pr-51729-move-diagnostics/near/128734054" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Matthew Jasper <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/pr-51729-move-diagnostics.html#128734054">(Jun 27 2018 at 19:41)</a>:</h4>
<p>re: first comment (creating a fake temporary to ensure things are Sized). The temporary is needed to avoid an ICE from box *x where x: Box&lt;[_]&gt;, I don't think the linked PR changes that.</p>



<a name="128734277"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/pr-51729-move-diagnostics/near/128734277" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/pr-51729-move-diagnostics.html#128734277">(Jun 27 2018 at 19:46)</a>:</h4>
<p>ah, ok</p>



<a name="128734280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/122657-t-compiler/wg-nll/topic/pr-51729-move-diagnostics/near/128734280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/122657-t-compiler/wg-nll/topic/pr-51729-move-diagnostics.html#128734280">(Jun 27 2018 at 19:46)</a>:</h4>
<p>sounds right</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>